solaris build environment should include libsendfile/liblgrp #94976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of version 0.2.120 of the libc crate, the solaris target now requires some additional libraries to be present in the sysroot. Note that the solaris target doesn't really build against files from Solaris, but rather against some files from DilOS (a platform similar to both Solaris and illumos). Pull in the extra libraries and their compilation links from that apt repository.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Note that I've looked in the apt repository I believe this docker image uses, and found the files I would expect to see, via: #!/bin/bash
set -o errexit
set -o pipefail
REPO=https://apt.dilos.org/dilos
A=dilos2
B=main
printf 'loading package manifest...\n'
pkgs=$(curl -sSf -L "$REPO/dists/$A/$B/binary-solaris-i386/Packages.gz" |
gunzip)
function file_for {
awk -v "p=$1" '
$1 == "Package:" && $2 == p { q = 1; }
/^$/ { q = 0; }
q && $1 == "Filename:" { print $2; }' <<< "$pkgs"
}
files=(
$(file_for libsendfile)
$(file_for libsendfile-dev)
$(file_for liblgrp)
$(file_for liblgrp-dev)
)
td="$(mktemp -d)"
for f in "${files[@]}"; do
b=$(basename "$f")
printf 'package: %s\n' "$b"
curl -sSfL -o "$td/$b" "$REPO/$f"
7z -so x "$td/$b" 2>/dev/null | tar tvf - | sed 's/^/ /'
printf '\n'
done
rm -rf "$td"This gives output: Will the CI pipeline produce the new docker image (dist-various-2) and use that to build the solaris target for this change, or do we need to do something extra to test that? |
|
@bors r+ rollup=iffy
Yep, this'll automatically rebuild the docker image and use that going forward. |
|
📌 Commit 0dcb175 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 0dcb175 with merge 442ea85c0cd3580482c8770a136fcc5cf7feb1e4... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry dist-i586-gnu-i586-i686-musl timed out in ui tests |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 0dcb175 with merge 311b962c39fc7eb88e6d977272d45253ef4489b3... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry x86_64-apple-2: The hosted runner: GitHub Actions 47 lost communication with the server. |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (183090f): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of version 0.2.120 of the libc crate, the solaris target now requires
some additional libraries to be present in the sysroot. Note that the
solaris target doesn't really build against files from Solaris, but
rather against some files from DilOS (a platform similar to both Solaris
and illumos). Pull in the extra libraries and their compilation links
from that apt repository.
This aims to assist with #94052.